Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/bank querier #278

Merged
merged 10 commits into from
Dec 4, 2023
Merged

Add/bank querier #278

merged 10 commits into from
Dec 4, 2023

Conversation

Kayanski
Copy link
Contributor

@Kayanski Kayanski commented Nov 28, 2023 •
edited
Loading

This PR aims at adding a Bank Querier capability to environments

Closes ORC-53

@Kayanski Kayanski marked this pull request as ready for review November 28, 2023 09:47
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0964352
Status:⚡️  Build in progress...

View logs

@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #278 (19fd041) into main (0f86c02) will increase coverage by 0.0%.
The diff coverage is 58.5%.

Additional details and impacted files
Files Coverage Δ
cw-orch-daemon/src/error.rs 14.2% <ø> (ø)
...ges/cw-orch-core/src/contract/contract_instance.rs 90.7% <ø> (ø)
...ages/cw-orch-core/src/contract/interface_traits.rs 69.2% <ø> (ø)
...-orch-core/src/environment/cosmwasm_environment.rs 0.0% <ø> (ø)
cw-orch-daemon/src/queriers/bank.rs 90.4% <0.0%> (-6.7%) ⬇️
packages/cw-orch-mock/src/core.rs 90.3% <78.9%> (-1.2%) ⬇️
packages/cw-orch-core/src/environment/mut_env.rs 0.0% <0.0%> (ø)
cw-orch/src/osmosis_test_tube/core.rs 66.0% <77.7%> (+8.8%) ⬆️
cw-orch-daemon/src/sync/core.rs 33.5% <0.0%> (-5.8%) ⬇️

@Kayanski Kayanski requested a review from CyberHoward November 28, 2023 10:09
@Kayanski Kayanski requested a review from CyberHoward November 29, 2023 13:09
CyberHoward
CyberHoward reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you removed WasmCodeQuerier for test-tube?

@Kayanski
Copy link
Contributor Author

It looks like you removed WasmCodeQuerier for test-tube?

No it's still there : https://github.com/AbstractSDK/cw-orchestrator/pull/278/files#diff-dd167dc186b892e4feafe2f689fde78aad72b168572a9fc89039f1ca21c9dd58L348

CyberHoward

This comment was marked as duplicate.

Sign in to view

CyberHoward
CyberHoward reviewed Dec 4, 2023
View reviewed changes
packages/cw-orch-core/src/environment/mut_env.rs Outdated
}
}

pub trait MutCwEnv: BankSetter + CwEnv {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Could this be moved to top of the file

@Kayanski Kayanski merged commit b5af0a7 into main Dec 4, 2023
3 of 4 checks passed
@Kayanski Kayanski deleted the add/bank-querier branch December 4, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberHoward CyberHoward CyberHoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kayanski @CyberHoward