Re use contracts wasm compilation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kayanski
changed the base branch from
adapt_for_local_execution
to
clone-test/cosmwasm-2
Kayanski
commented
Sep 4, 2024
| @@ -237,7 +236,7 @@ where | |||
| /// Registers contract code (like uploading wasm bytecode on a chain), | |||
| /// so it can later be used to instantiate a contract. | |||
| /// Only for wasm codes | |||
| pub fn store_wasm_code(&mut self, code: WasmContract) -> u64 { | |||
| pub fn store_wasm_code(&mut self, code: Vec<u8>) -> u64 { | |||
There was a problem hiding this comment.
This allows for cw-multi-test handling of module caching... The interface is also simpler for users
| @@ -128,7 +130,7 @@ pub trait Wasm<ExecC, QueryC: CustomQuery>: AllWasmQuerier { | |||
| pub type LocalRustContract<ExecC, QueryC> = *mut dyn Contract<ExecC, QueryC>; | |||
| pub struct WasmKeeper<ExecC: 'static, QueryC: CustomQuery + 'static> { | |||
| /// Contract codes that stand for wasm code in real-life blockchain. | |||
| pub code_base: HashMap<usize, WasmContract>, | |||
| pub code_base: RefCell<HashMap<usize, WasmContract>>, | |||
There was a problem hiding this comment.
Allows for storing new code modules while executing transactions and queries
| pub struct DistantCodeId { | ||
| pub code_id: u64, | ||
| pub module: (Engine, Module), |
There was a problem hiding this comment.
Engine and Modules go together and MUST be used together, otherwise segmentation faults can happen
There was a problem hiding this comment.
Wow, that's wild Engine that can't be reused with different module
|
|
||
| #[derive(Serialize, Deserialize, Debug)] | ||
| #[derive(Debug)] |
Kayanski
changed the title
2 tasks
CyberHoward
approved these changes
Sep 4, 2024
Buckram123
approved these changes
Sep 4, 2024
Kayanski
deleted the
nicolas/orc-161-re-use-contracts-wasm-compilation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at avoiding multiple compilation of wasm modules.