Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant asObservable #131

Closed
wajda opened this issue Sep 8, 2021 · 0 comments
Closed

Remove redundant asObservable #131

wajda opened this issue Sep 8, 2021 · 0 comments
Assignees
@wajda
Labels
Tech debt
Milestone
0.6.1

Comments

@wajda
Copy link
Contributor

wajda commented Sep 8, 2021 •
edited
Loading

Rx.Observable.asObservable() method is redundant throughout the code because the problem the method aims to solve at runtime is solved at the compile-time by TypeScript type system.

https://stackoverflow.com/a/69103339/96766
@wajda wajda transferred this issue from AbsaOSS/spline Sep 8, 2021
@wajda wajda changed the title Remove redundant asObservable Remove redundant asObservable Sep 8, 2021
@wajda wajda self-assigned this Sep 8, 2021
@wajda wajda added the Tech debt label Sep 8, 2021
@wajda wajda added this to the 0.6.1 milestone Sep 8, 2021
wajda added a commit that referenced this issue Sep 8, 2021
@wajda
issue #131 Remove redundant asObservable()
c898e3e
wajda added a commit that referenced this issue Sep 9, 2021
@wajda
issue #131 Remove redundant asObservable()
b7c1bc7
@wajda wajda closed this as completed Sep 10, 2021
@wajda wajda added this to Spline Mar 31, 2022
@wajda wajda moved this to New in Spline Mar 31, 2022
@wajda wajda moved this from New to Closed in Spline Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
Tech debt
Projects
Spline
Status: Done
Milestone
0.6.1
Development

No branches or pull requests
1 participant
@wajda