#501 Fix Jdbc Native treating of nullable fields. #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yruslan
force-pushed
the
bugfix/501-fix-jdbc-native-nullability
branch
from
a1c3a59 to
a4572ff
Compare
yruslan
commented
Oct 18, 2024
Comment on lines
+116
to
+117
| val v = rs.getBoolean(columnIndex) | ||
| if (rs.wasNull()) null else v |
There was a problem hiding this comment.
Very ugly, but it seems it is the way to go, at least for the maximum performance
There was a problem hiding this comment.
val rsValue = dataType match {
case BIT | BOOLEAN => rs.getBoolean(columnIndex)
case TINYINT => rs.getByte(columnIndex)
case SMALLINT => rs.getShort(columnIndex)
case INTEGER => rs.getInt(columnIndex)
case BIGINT => rs.getLong(columnIndex)
case FLOAT => rs.getFloat(columnIndex)
case DOUBLE => rs.getDouble(columnIndex)
case REAL => rs.getBigDecimal(columnIndex)
case NUMERIC => rs.getBigDecimal(columnIndex)
case DATE => sanitizeDate(rs.getDate(columnIndex))
case TIMESTAMP => sanitizeTimestamp(rs.getTimestamp(columnIndex))
case _ => rs.getString(columnIndex)
}
if (rs.wasNull()) null else rsValue?
There was a problem hiding this comment.
Yes, this looks much nicer indeed! Just it would call rs.wasNull() even when it is not necessary, so I still prefer the original approach.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #501
The fix is tested and confirmed working.