Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#483 Fix count() queries with MS SQL and other SQL dialects. #484

Merged
merged 1 commit into from
Sep 4, 2024
Merged

#483 Fix count() queries with MS SQL and other SQL dialects. #484

merged 1 commit into from
Sep 4, 2024

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Sep 3, 2024

Closes #483

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Unit Test Coverage

File Coverage [92.57%] 🍏
SqlGeneratorDenodo.scala 97.13% 🍏
SqlGeneratorDb2.scala 97.1% 🍏
SqlGeneratorHive.scala 97.08% 🍏
SqlGeneratorHsqlDb.scala 97.08% 🍏
SqlGeneratorPostgreSQL.scala 96.95% 🍏
SqlGeneratorGeneric.scala 96.95% 🍏
SqlGeneratorMySQL.scala 96.95% 🍏
SqlGeneratorSas.scala 94.62% 🍏
SqlGeneratorOracle.scala 93.2% 🍏
SqlGeneratorMicrosoft.scala 85.95% 🍏
TableReaderJdbc.scala 84.62% 🍏
Total Project Coverage 81.08% 🍏

@yruslan yruslan merged commit 518d96d into main Sep 4, 2024
8 checks passed
@yruslan yruslan deleted the bugfix/483-fix-sql-with-count-query branch September 4, 2024 14:49
@yruslan yruslan mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirRybalko VladimirRybalko VladimirRybalko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues running count queries against MS SQL
2 participants
@yruslan @VladimirRybalko