Bugfix/45 java gateway error #48
Conversation
ValeriiKhalimendik
force-pushed
the
bugfix/45-java-gateway-error
branch
from
d4bc409 to
9b00420
Compare
|
@zhukovgreen, it is strange that lint fails on files that @ValeriiKhalimendik hasn't changed. |
Maybe @ValeriiKhalimendik just didn't install the pre-commit hooks, in this case, git commit won't run them. To install git hooks you need to: pre-commit install --install-hooks |
…rtedFileSystemException: No FileSystem for scheme "C"
ValeriiKhalimendik
force-pushed
the
bugfix/45-java-gateway-error
branch
from
a5e7e7a to
ac6fc16
Compare
Some of the errors in mypy hook were simply ignored, this required further investigation
There was a problem hiding this comment.
I'd like to ask you to move the fix_uri_scheme_availability feature to a separate MR. It is adding additional complexity now and out of the scope of this MR. I am pretty sure it will be easier to have it apart.
PLease ignore my comments about this function. They are incomplete.
| @@ -52,10 +55,25 @@ def get_fs_from_uri(self, uri: str) -> "_FileSystem": | |||
| object (i.e. S3FileSystem, LocalFileSystem etc.) | |||
| """ | |||
| return self.FileSystem.get( | |||
| self.URI(uri), | |||
| self.URI(self.fix_uri_scheme_availability(uri)), | |||
There was a problem hiding this comment.
We are expecting the properly formatted uri at this place. The postprocessing of the config input is happening here https://github.com/AbsaOSS/pramen/blob/main/pramen-py/src/pramen_py/models/__init__.py#L73-L83.
There was a problem hiding this comment.
Good idea. But let's do it in a different PR.
|
Please, insert the license to Interestingly, I can add a comment to an empty file 😆 |
ValeriiKhalimendik
force-pushed
the
bugfix/45-java-gateway-error
branch
from
4974695 to
592b2a0
Compare
ValeriiKhalimendik
force-pushed
the
bugfix/45-java-gateway-error
branch
from
592b2a0 to
5931a34
Compare
No description provided.