Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#205 Allows spreading object array elements among multiple config files. #211

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Jun 16, 2023

I was trying several attempts and didn't like all of them.

  1. Reading configs separately as a TypeSafe Config and them combining them into a single Config object didn't work since it is not possible to add an array of objects to a config in runtime.
  2. Making multiple-configs-aware Sources/Sinks/Operations deserializer complicates Pramen code a lot, and requires enormous change across the project.

So I came with a compromise solution. See #205

@github-actions
Copy link

Unit Test Coverage

File Coverage [89.02%] 🍏
PipelineDef.scala 100% 🍏
MetaTable.scala 98.39% 🍏
ExternalChannelFactoryReflect.scala 88.54% 🍏
ConfigUtils.scala 82.59% 🍏
Total Project Coverage 79.01% 🍏

@yruslan yruslan marked this pull request as ready for review June 16, 2023 10:59
@yruslan yruslan requested a review from jirifilip as a code owner June 16, 2023 10:59
Copy link
Collaborator

@jirifilip jirifilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a nice and simple solution in the end, I like it :)

@yruslan yruslan merged commit 907f3b3 into main Jun 19, 2023
@yruslan yruslan deleted the feature/205-multiple-workflow-configs branch June 19, 2023 06:21
@yruslan yruslan mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants