Improve StandardizationSink #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yruslan
commented
Jun 14, 2023
yruslan
commented
- Add support for Delta as the format of the raw layer.
- Add support for Delta as the format of the publish layer.
- Add support for customizing partition columns of the publish layer.
- Allow column transformations to use information date in expressions.
yruslan
commented
Jun 14, 2023
| @@ -245,7 +247,13 @@ abstract class TaskRunnerBase(conf: Config, | |||
| case None => runResult.data | |||
| } | |||
|
|
|||
| val postProcessed = task.job.postProcessing(dfWithTimestamp, task.infoDate, conf) | |||
| val dfWithInfoDate = if (dfWithTimestamp.schema.exists(f => f.name.equals(task.job.outputTable.infoDateColumn))) { | |||
There was a problem hiding this comment.
This is the only change in the framework itself. The rest is Enceladus-specific.
| @@ -336,10 +336,12 @@ class TaskRunnerBaseSuite extends AnyWordSpec with SparkTestBase with TextCompar | |||
| """[ { | |||
| | "a" : "B", | |||
| | "b" : 2, | |||
| | "INFO_DATE" : "2022-02-18", | |||
There was a problem hiding this comment.
And this is the test for the new logic - the information date is now available after a jobs has run, even before it is saved.
Unit Test Coverage
|
jirifilip
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.