Make AppRunner recreate AppContext on every run #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Coverage
|
yruslan
approved these changes
Jun 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit some issues on Databricks where, if we run a Pramen job repeatedly on an all-purpose cluster or in a notebook, the
AppContextgets created only once. In theAppContextcreation process, metastore config is parsed and configured. Thus, if we change the metastore config between runs on an all-purpose cluster, it has no effect on the pipeline run, since Pramen will be using an already createdAppContextfrom the JVM process (with old metastore table definitions).So far did not remove any dead code (
AppContextFactoryand its tests) in case we would like to use it in the future.