Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/182 add custom query type #183

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Apr 3, 2023

Add support for custom queries for data sources (#182).

These are queries that cannot fit the standard set of table, sql, path.

I also included a tiny fix in this PR. Notification email subject was reporting date and time in the system timezone. I've noticed it since on AWS the system timezone is UTC. The fix is to honor the timezone configured in Pramen configuration.

These are queries that cannot fit the standard set of `table`, `sql`, `path`.
@yruslan yruslan force-pushed the feature/182-add-custom-query-type branch from efca387 to 0d9d891 Compare April 3, 2023 15:54
@yruslan yruslan marked this pull request as ready for review April 4, 2023 08:13
@yruslan yruslan requested a review from jirifilip as a code owner April 4, 2023 08:13
Copy link
Collaborator

@jirifilip jirifilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, good spot with the timezone!

@yruslan yruslan merged commit 8f26df1 into main Apr 5, 2023
@yruslan yruslan deleted the feature/182-add-custom-query-type branch April 5, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants