Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#153 Fix pipeline does not publish task completion events to the journal table. #154

Merged
merged 2 commits into from
Feb 7, 2023
Merged

#153 Fix pipeline does not publish task completion events to the journal table. #154

merged 2 commits into from
Feb 7, 2023

Conversation

yruslan
Copy link
Collaborator

@yruslan yruslan commented Feb 6, 2023

  • The journal table has quite a legacy format for compatibility with SyncWatcher. Maybe the journal can be deprecated in the future, or made optional
  • Extended RunStatus with additional methods since these reasons are pattern matched and rendered for different reasons. New methods unify the way these status messages are rendered.
  • Tested end to end

@yruslan yruslan marked this pull request as ready for review February 6, 2023 12:34
@yruslan yruslan requested a review from jirifilip as a code owner February 6, 2023 12:34
jirifilip
jirifilip approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator

@jirifilip jirifilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yruslan yruslan merged commit ab64f08 into main Feb 7, 2023
@yruslan yruslan deleted the bugfix/153-jourlal-add branch February 7, 2023 08:52
@yruslan yruslan mentioned this pull request Mar 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirifilip jirifilip jirifilip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yruslan @jirifilip