Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more info to TaskStatus for notifications #423

Closed
yruslan opened this issue Jun 7, 2024 · 5 comments
Closed

Add more info to TaskStatus for notifications #423

yruslan opened this issue Jun 7, 2024 · 5 comments
Assignees
Labels
DE enhancement New feature or request Pramen-Scala

Comments

@yruslan
Copy link
Collaborator

yruslan commented Jun 7, 2024

Background

There are some bits of information that is present in the pipeline state, but missing for notification targets, including:

  • val isFailure: Boolean
  • maybe more coming...

Feature

Add the missing information to the TaskStatus model objects so that notification targets other then email have access to the same info as email notification

Example

--

Proposed Solution

As an additional suggestion - add access to pipeline state via PipelineState trait if client includes pramen-core as a dependency, not just pramen-api

@yruslan yruslan added enhancement New feature or request Pramen-Scala DE labels Jun 7, 2024
@jozefbakus
Copy link

jozefbakus commented Jun 10, 2024

I would also add:

  • pipelineName
  • environmentName
    from PipelineNotification to WebhookNotificationTarget

@yruslan
Copy link
Collaborator Author

yruslan commented Jun 10, 2024

Great, will add

@jozefbakus
Copy link

++ There is difference in Skipped status between TaskStatus and RunStatus. Missing isWarning

@jozefbakus
Copy link

Also missing notification warning/errors ... I am thinking is there a difference between classes and why not have have the same classes for both

@yruslan yruslan self-assigned this Jun 14, 2024
yruslan added a commit that referenced this issue Jun 14, 2024
yruslan added a commit that referenced this issue Jun 17, 2024
yruslan added a commit that referenced this issue Jun 17, 2024
yruslan added a commit that referenced this issue Jun 17, 2024
yruslan added a commit that referenced this issue Jun 20, 2024
yruslan added a commit that referenced this issue Jun 20, 2024
yruslan added a commit that referenced this issue Jun 20, 2024
yruslan added a commit that referenced this issue Jun 20, 2024
@kevinwallimann
Copy link
Contributor

Closed by #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DE enhancement New feature or request Pramen-Scala
Projects
None yet
Development

No branches or pull requests

3 participants