Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of config arrays in logs #113

Closed
yruslan opened this issue Jan 3, 2023 · 0 comments
Closed

Improve rendering of config arrays in logs #113

yruslan opened this issue Jan 3, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@yruslan
Copy link
Collaborator

yruslan commented Jan 3, 2023

Background

Pramen logs the incoming config in order to make investigating issues easier.

However, Pramen configs have many arrays (pramen.sources, pramen.sinks, etc).

And these arrays are not properly rendered, and secrets are not properly redacted.

pramen.sources = [{factory={class=za.co.absa.pramen.core.source.SparkSource}, name=csv, format=csv, has={information=
{date={column=false}}}, option={delimiter=,, header=true}}, notification.targets=["a", "b", "c"], {factory={class=za.co.absa.pramen.core.source.JdbcSource}, 
correct={decimals={in={schema=true}}}, name=postgre, save={timestamps={as={dates=true}}}, jdbc={password=test, 
driver=org.postgresql.Driver, connection={primary={url=jdbc:postgresql://test/db}}, user=test_user}, information={date={app=
{format=yyyy-MM-dd}, column=info_date, type=date, sql={format=YYYY-MM-DD}}}, has={information={date={column=true}}}, 
option={fetchsize=50000, batchsize=50000}},

Feature

Improve the rendering of arrays and make one log line per primitive value, or per array of primitive values.

Example

pramen.sources[0].factory.class="za.co.absa.pramen.core.source.SparkSource"
pramen.sources[0].name="csv"
pramen.sources[0].format="csv"
pramen.sources[0].notification.targets=["a"  "b"  "c"]
...
pramen.sources[1].jdbc.password=[ redacted ]
...
@yruslan yruslan added the enhancement New feature or request label Jan 3, 2023
jirifilip added a commit that referenced this issue Jan 9, 2023
#113 Improved rendering of config arrays and objects in logs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants