Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow design recommendations #9

Merged
merged 1 commit into from
May 26, 2021
Merged

Follow design recommendations #9

merged 1 commit into from
May 26, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Apr 20, 2021

ytsarev
ytsarev approved these changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adopting best practices

@kuritka kuritka merged commit c780be4 into main May 26, 2021
@kuritka kuritka deleted the update-naming branch May 26, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

@donovanmuller donovanmuller Awaiting requested review from donovanmuller donovanmuller is a code owner

@k0da k0da Awaiting requested review from k0da k0da is a code owner

@somaritane somaritane Awaiting requested review from somaritane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuritka @ytsarev