Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopkg v0.1.1 #6

Merged
merged 1 commit into from
Mar 19, 2021
Merged

gopkg v0.1.1 #6

merged 1 commit into from
Mar 19, 2021

Conversation

kuritka
Copy link
Collaborator

@kuritka kuritka commented Mar 19, 2021

In order to breaking change in controller-runtime v0.8.3 I decided to:

  • remove controller package (temporarly)
  • fix documentation

In order to breaking change controller-runtime version I decided to remove
 - remove controller package
 - fix documentation
Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me:

  • What we are losing by removing the controller package
  • If documentation fixes are anyhow related to the problem
  • Why go.mod was downloading the Internet before this change

@kuritka
Copy link
Collaborator Author

kuritka commented Mar 19, 2021

The problem is module sigs.k8s.io/controller-runtime v0.8.3 which has many dependencies. That's why go.sum grew into giant dimension. We lost nothing as v0.1.0 was not used yet. Also controller was moved from k8gb here, but it can stay where it is (https://github.com/AbsaOSS/k8gb/blob/master/controllers/internal/utils/reconciler_result.go).

The whole problem is, that k8gb uses sigs.k8s.io/controller-runtime version A while gopkg may use sigs.k8s.io/controller-runtime version B. Which is not blocker but package tree behind sigs.k8s.io/controller-runtime is so large that it can't simply cooperate together without replaces, exclude etc in go.mod.

Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarifications.

I need to think it through but in general I wouldn't move the code related to Reconciliation outside of k8gb controller

@kuritka
Copy link
Collaborator Author

kuritka commented Mar 19, 2021

@ytsarev, yes that's true. I was thinking a lot if I should move this part or not. Basically, it's just a helper. Maybe it is better if this concrete helper stays in k8gb

@kuritka kuritka merged commit 3f998c5 into main Mar 19, 2021
@kuritka kuritka deleted the gopkg-controller branch March 19, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants