#139: Cannot add new additionalInfo in metadata #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mockito-scala upgraded 1.15.0 -> 1.17.12, spark 3.2.1 -> 2
benedeki
requested review from
lsulak,
dk1844,
Zejnilovic,
miroslavpojer,
jakipatryk and
HuvarVer
lsulak
previously approved these changes
Oct 21, 2022
There was a problem hiding this comment.
- code reviewed
- pulled
- built
- ran tests (confirmed that without the change in
Accumulator.scala, the new tests failed)
However, the CI is failing for Spark 3.2.1 & Scala 2.12.15. I ran build-all.sh on my localhost and everything works.
It's in HdfsInfoIntegrationSuite (btw this file contains a couple of unused imports), but I don't see anything suspicious there
lsulak
approved these changes
Oct 24, 2022
dk1844
approved these changes
Oct 24, 2022
miroslavpojer
approved these changes
Oct 25, 2022
benedeki
deleted the
bugfix/139-cannot-add-new-additionalinfo-in-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of the bug plus unit tests.
Closes #139