#131 Backport of jackson serialization support (RunStatus enum) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field of RunState enum) (CP'd from PR #84) - unit test cases for this has been added
dk1844
requested review from
Zejnilovic,
AdrianOlosutean and
benedeki
and removed request for
AdrianOlosutean,
benedeki and
Zejnilovic
… is incompatible)
AdrianOlosutean
previously approved these changes
May 25, 2022
benedeki
previously approved these changes
May 26, 2022
| @@ -154,6 +155,16 @@ | |||
| <artifactId>spark-core_${scala.binary.version}</artifactId> | |||
| <version>${spark.version}</version> | |||
| <scope>provided</scope> | |||
| <exclusions> | |||
There was a problem hiding this comment.
These exclusions are missing from sbt. Is that OK?
There was a problem hiding this comment.
Thanks for noticing. I have added the same excludes to sbt version as well.
| case class RunStatus | ||
| ( | ||
| @JsonScalaEnumeration(classOf[RunStateType]) |
There was a problem hiding this comment.
Just a note: The whole class feels little utilitarian for Enceladus' purposes. But no point of removing it now..
There was a problem hiding this comment.
No such class in the next major version 👍
benedeki
approved these changes
May 26, 2022
dk1844
deleted the
feature/131-run-state-enum-serialization-backport-to-v3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of Jackson serialization support (
RunStatusenum) (cherry-picked from PR #84)As for the potential backwards compatibility issue: RunStatus serialization with Jackson was actually never used, Json4s serialization was always used instead. (
SerializationUtils.asJson)Closes #131