Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to prepend a Checkpoint #75

Closed
Zejnilovic opened this issue May 3, 2021 · 2 comments · Fixed by #76
Closed

Add ability to prepend a Checkpoint #75

Zejnilovic opened this issue May 3, 2021 · 2 comments · Fixed by #76
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Zejnilovic
Copy link
Collaborator

Add ability to prepend a Checkpoint to ControlMeasure and in builder with withPreceedingChekpoint(checkpoint)
@Zejnilovic Zejnilovic added enhancement New feature or request good first issue Good for newcomers labels May 3, 2021
@dk1844
Copy link
Collaborator

dk1844 commented May 3, 2021

I believe the first checkpoint usually has order = 1. Should we check/warn if this is the case or do should we just allow users to use the model in any way they like (that is possible)

dk1844 added a commit that referenced this issue May 3, 2021
@dk1844
#75 adding the ability to prepend a checkpoint + unit test
1489735
dk1844 added a commit that referenced this issue May 3, 2021
@dk1844
#75 adding the ability to prepend a checkpoint + unit test
9f7e81b
dk1844 added a commit that referenced this issue May 4, 2021
@dk1844
#75 licence update, readme update: ControlMeasure.withPrecedingCheckp…
61b42d3 
…oint
dk1844 added a commit that referenced this issue May 4, 2021
@dk1844
#75 doc update
74c45e2
dk1844 added a commit that referenced this issue May 4, 2021
@dk1844
#75 adding the ability to prepend a checkpoint + unit test (#76)
dfe2c1f 
* #75 adding the ability to prepend a checkpoint inside a ControlMeasure + unit test, readme update
@dk1844
Copy link
Collaborator

dk1844 commented May 4, 2021

Implemented in #76.

@dk1844 dk1844 closed this as completed May 4, 2021
@dk1844 dk1844 linked a pull request May 11, 2021 that will close this issue
#75 adding the ability to prepend a checkpoint + unit test #76
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#75 adding the ability to prepend a checkpoint + unit test AbsaOSS/atum
2 participants
@dk1844 @Zejnilovic