Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: animation: cursor | random #10

Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat: animation: cursor | random #10

merged 1 commit into from
Oct 10, 2024

Conversation

Aliqyan-21
Copy link
Contributor

PR for the issue #7:

  • Refactored Cursor Tracking Logic: added the keep_within_vicinity function to ensure the beastie remains within a specified radius of the cursor, preventing it from going off-screen. Also I had to adjust The minimum row position to prevent overlapping with other UI elements.

  • Enhanced Cursor Jump Detection: I added the detect_cursor_jump function to reposition the beastie more responsively when large cursor movements are detected, improving the overall animation fluidity and user experience.

  • Still a little buggy when dealing with scrolling down and up of the buffer.

@Abizrh
Copy link
Owner

Abizrh commented Oct 10, 2024

so far it LGTM, I'll definitely merge it 🤠. Thanks a lot @Aliqyan-21

and for the bug you mentioned I'll be working on that

@Aliqyan-21
Copy link
Contributor Author

Thank you @Abizrh!

@Abizrh Abizrh merged commit c335abc into Abizrh:main Oct 10, 2024
@Aliqyan-21
Copy link
Contributor Author

Hello @Abizrh can you please add hacktoberfest accepted label to my PR?

As this shows on the website:

"Your PR was submitted to a repository that is not participating in Hacktoberfest. Maintainers need to add the hacktoberfest topic to the repository, or add the hacktoberfest-accepted label to your PR."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants