Add labelWidth prop to stacked bar charts #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanKramer
commented
Aug 2, 2024
| @@ -77,7 +77,12 @@ const RenderStackBars = (props: StackedBarChartPropsType) => { | |||
| style={[ | |||
| { | |||
| width: | |||
| (item.stacks[0].barWidth || props.barWidth || 30) + spacing / 2, | |||
| (item.labelWidth || | |||
| props.labelWidth || | |||
There was a problem hiding this comment.
This won't work until Abhinandan-Kushwaha/gifted-charts-core#36 is merged
Abhinandan-Kushwaha
approved these changes
Aug 2, 2024
|
Thanks for the PR @nathanKramer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on Abhinandan-Kushwaha/gifted-charts-core#36
Follows the established pattern for bar charts to allow customizing label width on stacked bar charts.
This is needed to fix my stacked bar chart, where two stacked bars are close together under one label:
Labels with
labelWidthlook like this: