Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(installation): Provide a backup git reference when tag can't be curl
closes rust-lang#423 If the parsed JSON data curled during a bash installation is not valid, use the repository's tag files as a backup. If those files don't exist somehow, then checkout the master branch and install it.
- Loading branch information
9e4fb10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ls -tr .git/refs/tags/
(with my clone of rustlings version 3.0.0 on linux) is empty (or should I say None() ?)git tag|tail -n1
(with git version 2.20.1) is3.0.0
( Some(3.0.0) )If the issue is a problem with the local install of python, (the migration from python2 to python3 is still causing some problems) and curl and the network are functioning then we could use the native shell script to process the JSON, before falling back to digging through the git repo itself as a last resort.
I have sketched out my native shell example here