Add cardZIndex prop #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's merge this PR!!! |
AaronCCWong
requested changes
Mar 26, 2019
There was a problem hiding this comment.
Thanks for working on this! There's no need to submit the lib files. If it's not too much extra work can you remove those changes? Otherwise you can leave it.
Other than that, I think this is good to go once we can default cardZIndex to auto so that we don't have an empty value if the user does not set this.
|
I'll hit these updates today and push again. |
AaronCCWong
approved these changes
Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prop should help with context stack issues while using multiple flip cards. You will want to apply a reversed z-Index order to your flip cards (last card 1, first card 100). This will allow child elements of flip cards to overlap other flip cards.
fixes #40