chore: bump golangci-lint to v1.63.4 and list argo-cd linters (argopr…

…oj#670)

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Aaron Hoffman <31711338+Aaron-9900@users.noreply.github.com>

.github/workflows/ci.yaml

@@ -27,8 +27,8 @@ jobs:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@971e284b6050e8a5849b72094c50ab08da042db8 # v6.1.1
         with:
-          version:  v1.58.2
-          args: --timeout 5m
+          version:  v1.63.4
+          args: --verbose
       - uses: codecov/codecov-action@a2f73fb6db51fcd2e0aa085dfb36dea90c5e3689 # v5.0.2
         with:
           token: ${{ secrets.CODECOV_TOKEN }} #required

.golangci.yaml

@@ -7,12 +7,42 @@ issues:
   max-same-issues: 0
 linters:
   enable:
+    - errcheck
+#    - errorlint
+    - gocritic
     - gofumpt
+#    - goimports
+    - gomodguard
     - gosimple
+    - govet
+    - importas
+    - ineffassign
+#    - misspell
+    # Disabled because of https://github.com/argoproj/argo-cd/issues/21705
+    # - nolintlint
+#    - perfsprint
     - revive
+    - staticcheck
     - testifylint
+#    - thelper
+#    - unparam
+    - unused
+    - usestdlibvars
     - whitespace
 linters-settings:
+  gocritic:
+    disabled-checks:
+      - appendAssign
+      - assignOp # Keep it disabled for readability
+      - commentFormatting #FIXME
+      - exitAfterDefer
+      - elseif #FIXME
+      - ifElseChain #FIXME
+      - mapKey
+      - singleCaseSwitch #FIXME
+      - typeSwitchVar
+      - unlambda #FIXME
+      - wrapperFunc #FIXME
   revive:
     # https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md
     rules: