Adapt storage #32
Merged
Adapt storage #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding the Note, there were many dependencies that needs to be fixed: 1. Adding a note list to person 2. Changing the constructor of person 3. EditCommand which used the constructor of person 4. Sample data in util. However, these fixes were superficial as Note is not finalised.
Closed
larrywang0701
approved these changes
Oct 11, 2023
larrywang0701
merged commit 81bd968
into
AY2324S1-CS2103T-W16-1:master
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified
Storageto read and save new features (EventandNote).In the processing of doing so, skeleton versions of
EventandNotewere added . They are not complete and needs to be properly implemented later. However, as long as the fields and method signatures of the current skeleton version remains unchanged,Storagewill work as intended.Lastly,
Personand other dependencies were modified to incorporate the newly addedEventandNote. Again, they are not complete and need to be modified once Event and Note are finalized.