Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update PPP #212

Merged
merged 2 commits into from
Nov 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions docs/team/nixx162.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,45 @@ Given below are my contributions to the team:

* **Project management**:
* Went through all the issues in GitHub to create a summary of what bugs there are (eliminating duplicate reports), whether they can be fixed, and recommended ideas of fixing it.
* Managed the CI and repo setup to establish best practices

* **Enhancements to existing features**:
* Improved help feature to better accomodate users. The old help command only opens a window containing a link to the user guide. The improvements I implemented are:
* [#43](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/43) Improved help feature to better accomodate users. The old help command only opens a window containing a link to the user guide. The improvements I implemented are:

* Calling the help command now display the list of all available commands

* Calling the help command with the relevant command word will display the uses of that command word

* Help command can recognize small typos in the additional argument and can suggest a correction
* Improved UI of the original contact list. Since initially all fields in a person instance is shown vertically, this leaves a lot of weight space in the right part of the window. Additionally, the density of information can make it hard to read. Therefore, I modified the display container to be a table instead.
* Improved UX when calling `list events`. Previously, the events are displayed as a text shown in the `ResultDisplay` container, which:

* [#77](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/77) Improved UI of the original contact list. Since initially all fields in a person instance is shown vertically, this leaves a lot of weight space in the right part of the window. Additionally, the density of information can make it hard to read. Therefore, I modified the display container to be a table instead.

* [#82](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/82) Improved UX when calling `list events`. Previously, the events are displayed as a text shown in the `ResultDisplay` container, which:

1. Can only show a small amount of rows, forcing the user to scroll
2. Is information-dense and unpleasant to read

Therefore, similar to the previous solution, I displayed the result, using a popup window, in a table as well.

* [#152](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/152) Did bug-fixes related to these features after PE-D

* **Documentation**:
* User Guide:
* Proofread the UG and fixed some typos, grammatical errors, and misrepresentations.
* Developer Guide:
* Modified the existing UML to fit the current state of our project
* Formatted and added some test cases to the manual testing section
* Discussed implementation details of the improved help feature in the DG\
* [#178](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/178), [#205](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/205) Modified the existing UML to fit the current state of our project
* [#187](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/187) Formatted and added some test cases to the manual testing section
* Discussed implementation details of the improved help feature in the DG

- **Review/mentoring contributions**

- Pull requests reviewed:

- [#33](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/33)

- Give advice on how to achieve certain things by understanding the codebase.
Example: Change from [#68](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/68) to [#72](https://github.com/AY2324S1-CS2103T-W16-1/tp/pull/72)

- **Contributions beyond the project team**

- Reported 11 bugs to other team's product during PE-D
Loading