Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various code quality fixes #331

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Various code quality fixes #331

merged 1 commit into from
Nov 6, 2022

Conversation

junweimoo
Copy link

No description provided.

@junweimoo junweimoo added this to the v1.4 milestone Nov 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 65.19% // Head: 65.25% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (68802af) compared to base (570572e).
Patch coverage: 70.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #331      +/-   ##
============================================
+ Coverage     65.19%   65.25%   +0.05%     
- Complexity      680      682       +2     
============================================
  Files           112      112              
  Lines          2270     2271       +1     
  Branches        253      253              
============================================
+ Hits           1480     1482       +2     
+ Misses          693      692       -1     
  Partials         97       97              
Impacted Files Coverage Δ
...edu/address/logic/commands/EditMeetingCommand.java 0.00% <0.00%> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 98.14% <ø> (-0.04%) ⬇️
...main/java/seedu/address/model/client/Birthday.java 21.87% <0.00%> (ø)
...c/main/java/seedu/address/model/client/Client.java 84.84% <0.00%> (ø)
src/main/java/seedu/address/model/MyInsuRec.java 84.05% <100.00%> (+0.72%) ⬆️
.../main/java/seedu/address/model/client/Address.java 72.72% <100.00%> (ø)
...rc/main/java/seedu/address/model/client/Email.java 72.72% <100.00%> (ø)
.../java/seedu/address/storage/JsonAdaptedClient.java 82.27% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@junweimoo junweimoo merged commit 3b2e714 into master Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants