Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Cases for ListMeeting and Improve Code Quality #326

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

junweimoo
Copy link

No description provided.

@junweimoo junweimoo added this to the v1.4 milestone Nov 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2022

Codecov Report

Base: 64.63% // Head: 65.19% // Increases project coverage by +0.55% 🎉

Coverage data is based on head (43f437b) compared to base (ab21519).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #326      +/-   ##
============================================
+ Coverage     64.63%   65.19%   +0.55%     
- Complexity      672      680       +8     
============================================
  Files           112      112              
  Lines          2268     2270       +2     
  Branches        252      253       +1     
============================================
+ Hits           1466     1480      +14     
+ Misses          707      693      -14     
- Partials         95       97       +2     
Impacted Files Coverage Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 98.18% <ø> (+12.72%) ⬆️
...edu/address/logic/commands/ListMeetingCommand.java 78.57% <25.00%> (-21.43%) ⬇️
...address/logic/parser/ListMeetingCommandParser.java 100.00% <100.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sikai00 sikai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sikai00 sikai00 merged commit a7f191d into master Nov 6, 2022
@ThomasHoooo ThomasHoooo deleted the chore-listmeeting-code-quality branch November 6, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants