Standardize EditClientCommand error msgs #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 63.26% // Head: 63.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #318 +/- ##
============================================
- Coverage 63.26% 63.17% -0.09%
Complexity 650 650
============================================
Files 112 112
Lines 2273 2273
Branches 266 268 +2
============================================
- Hits 1438 1436 -2
- Misses 736 737 +1
- Partials 99 100 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sikai00
reviewed
Nov 5, 2022
| @@ -82,7 +83,9 @@ public CommandResult execute(Model model) throws CommandException { | |||
| Client clientToEdit = lastShownList.get(index.getZeroBased()); | |||
| Client editedClient = createEditedClient(clientToEdit, editClientDescriptor); | |||
|
|
|||
| if (!clientToEdit.isSameClient(editedClient) && model.hasClient(editedClient)) { | |||
| if (clientToEdit.equals(editedClient)) { | |||
There was a problem hiding this comment.
good implementation of differentiating changes or no changes
sikai00
reviewed
Nov 5, 2022
| // no field specified | ||
| assertParseFailure(parser, " i/1", EditClientCommand.MESSAGE_NOT_EDITED); | ||
| String expectedMessage = String.format(MESSAGE_INVALID_COMMAND_FORMAT, EditClientCommand.MESSAGE_USAGE); | ||
| assertParseFailure(parser, VALID_NAME_AMY, expectedMessage); | ||
|
|
||
| // no index and no field specified |
There was a problem hiding this comment.
just a sidenote, in keeping with the heuristic to test one at a time, you might want to separate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.