Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

271 fix missing error message #289

Merged
merged 4 commits into from
Nov 2, 2022
Merged

Conversation

ThomasHoooo
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022

Codecov Report

Base: 59.89% // Head: 60.08% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (f293c27) compared to base (704b97a).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     59.89%   60.08%   +0.18%     
+ Complexity      614      610       -4     
============================================
  Files           113      112       -1     
  Lines          2254     2242      -12     
  Branches        249      249              
============================================
- Hits           1350     1347       -3     
+ Misses          821      813       -8     
+ Partials         83       82       -1     
Impacted Files Coverage Δ
.../address/logic/parser/AddMeetingCommandParser.java 0.00% <0.00%> (ø)
...ddress/logic/parser/DeleteClientCommandParser.java 81.81% <0.00%> (-18.19%) ⬇️
...dress/logic/parser/DeleteMeetingCommandParser.java 77.77% <0.00%> (-2.23%) ⬇️
...dress/logic/parser/DeleteProductCommandParser.java 77.77% <0.00%> (-2.23%) ⬇️
.../address/logic/parser/ListClientCommandParser.java 33.33% <0.00%> (-5.13%) ⬇️
...address/logic/parser/ListMeetingCommandParser.java 0.00% <0.00%> (ø)
...va/seedu/address/logic/parser/MyInsuRecParser.java 60.00% <ø> (-1.54%) ⬇️
...address/logic/parser/ViewMeetingCommandParser.java 75.00% <0.00%> (-2.78%) ⬇️
...u/address/logic/parser/AddClientCommandParser.java 100.00% <100.00%> (+22.72%) ⬆️
.../address/logic/parser/AddProductCommandParser.java 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sikai00 sikai00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small issue

@ThomasHoooo ThomasHoooo merged commit c770fe7 into master Nov 2, 2022
@ThomasHoooo ThomasHoooo added this to the v1.4 milestone Nov 3, 2022
@Thing1Thing2 Thing1Thing2 deleted the 271-fix-missing-error-message branch November 5, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Invalid Command format message does not appear for delClient
3 participants