Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and make command format more consistent #288

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

sikai00
Copy link
Member

@sikai00 sikai00 commented Oct 30, 2022

Closes #275.

@sikai00 sikai00 added this to the v1.4 milestone Oct 30, 2022
@sikai00 sikai00 self-assigned this Oct 30, 2022
@sikai00 sikai00 added type.Chore Something that needs to be done, but not a story, bug, or an epic. type.Bug A bug severity.Low A flaw that is unlikely to affect normal operations of the product. labels Oct 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2022

Codecov Report

Base: 59.89% // Head: 59.92% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (6573ba3) compared to base (ef24a62).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #288      +/-   ##
============================================
+ Coverage     59.89%   59.92%   +0.03%     
- Complexity      614      616       +2     
============================================
  Files           113      113              
  Lines          2254     2256       +2     
  Branches        249      249              
============================================
+ Hits           1350     1352       +2     
  Misses          821      821              
  Partials         83       83              
Impacted Files Coverage Δ
...eedu/address/logic/commands/AddMeetingCommand.java 0.00% <0.00%> (ø)
...du/address/logic/commands/DeleteClientCommand.java 100.00% <ø> (ø)
...u/address/logic/commands/DeleteProductCommand.java 100.00% <ø> (ø)
...eedu/address/logic/commands/EditClientCommand.java 89.47% <ø> (ø)
...edu/address/logic/commands/EditMeetingCommand.java 0.00% <ø> (ø)
...eedu/address/logic/commands/ViewClientCommand.java 100.00% <ø> (ø)
...edu/address/logic/commands/ViewMeetingCommand.java 92.30% <ø> (ø)
...seedu/address/logic/commands/AddClientCommand.java 88.23% <100.00%> (ø)
...eedu/address/logic/commands/AddProductCommand.java 91.66% <100.00%> (ø)
...u/address/logic/commands/DeleteMeetingCommand.java 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sikai00 sikai00 removed their assignment Oct 30, 2022
@sikai00 sikai00 merged commit e25e21b into master Nov 1, 2022
@sikai00 sikai00 deleted the chore-fix-invalid-command-format branch November 2, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity.Low A flaw that is unlikely to affect normal operations of the product. type.Bug A bug type.Chore Something that needs to be done, but not a story, bug, or an epic.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester A] Invalid command format message for all commands with index could include the i prefix
2 participants