Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all UG issues as per PE-D #279

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Fix all UG issues as per PE-D #279

merged 2 commits into from
Oct 29, 2022

Conversation

sikai00
Copy link
Member

@sikai00 sikai00 commented Oct 29, 2022

Closes #255 and #261.

@sikai00 sikai00 added the User Guide Documention issue in User Guide. label Oct 29, 2022
@sikai00 sikai00 added this to the v1.4 milestone Oct 29, 2022
@sikai00 sikai00 self-assigned this Oct 29, 2022
@sikai00 sikai00 linked an issue Oct 29, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2022

Codecov Report

Base: 59.89% // Head: 59.89% // No change to project coverage 👍

Coverage data is based on head (3837e33) compared to base (13af669).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #279   +/-   ##
=========================================
  Coverage     59.89%   59.89%           
  Complexity      614      614           
=========================================
  Files           113      113           
  Lines          2254     2254           
  Branches        249      249           
=========================================
  Hits           1350     1350           
  Misses          821      821           
  Partials         83       83           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sikai00 sikai00 marked this pull request as ready for review October 29, 2022 13:00

**Q**: I accidentally closed the app, will my data still be there?<br>
**A**: Yes, your data is saved automatically after every action.

**Q**: My computer does not recognise the file type jar. How do I open the app?<br>
**A**: Install Java version 11 and above from the official Java website.
**A**: Check if your computer already has Java 11 or above install from [8.1 Checking your system's Java version](#81-checking-your-systems-java-version). If not, follow the instructions to install Java.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installed instead of install for the first sentence. Just a minor grammar issue

Copy link

@ThomasHoooo ThomasHoooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sikai00 sikai00 merged commit 236e826 into master Oct 29, 2022
@sikai00 sikai00 deleted the chore-update-ug-general branch October 29, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Guide Documention issue in User Guide.
Projects
None yet
3 participants