Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListClient by product #190

Merged
merged 4 commits into from
Oct 27, 2022
Merged

ListClient by product #190

merged 4 commits into from
Oct 27, 2022

Conversation

ThomasHoooo
Copy link

No description provided.

@ThomasHoooo ThomasHoooo added this to the v1.3 milestone Oct 24, 2022
@ThomasHoooo ThomasHoooo linked an issue Oct 24, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Base: 64.67% // Head: 64.70% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (cb7b5de) compared to base (9a3f333).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
+ Coverage     64.67%   64.70%   +0.02%     
- Complexity      610      613       +3     
============================================
  Files           108      109       +1     
  Lines          2058     2068      +10     
  Branches        222      223       +1     
============================================
+ Hits           1331     1338       +7     
- Misses          652      654       +2     
- Partials         75       76       +1     
Impacted Files Coverage Δ
...eedu/address/logic/commands/ViewClientCommand.java 100.00% <ø> (ø)
.../address/logic/parser/ListClientCommandParser.java 62.50% <62.50%> (ø)
...eedu/address/logic/commands/ListClientCommand.java 100.00% <100.00%> (ø)
...u/address/logic/parser/AddClientCommandParser.java 77.27% <100.00%> (ø)
...va/seedu/address/logic/parser/MyInsuRecParser.java 64.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

} else {
Product product = ParserUtil.parseProduct(argumentMultimap.getValue(PREFIX_PRODUCT).get());
return new ListClientCommand(client -> client.hasProduct(product));
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to pass the product straight to the ListClientCommand and then form the predicate inside the command itself. IMO, the parser classes should be concerned with parsing only (i.e. turning the argument strings into the command).

Copy link

@rexong rexong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ThomasHoooo ThomasHoooo merged commit 382ca44 into master Oct 27, 2022
@ThomasHoooo ThomasHoooo deleted the feat-viewclient-by-product branch October 27, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

viewClient by product
4 participants