Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code snippet causing the bug. command result is needed to know if the ui should show persons as details or not. however, when the result is received, the model is updated already (model updates during execution) and setting show details does not update the personlistpanel component, so we have to explicitly tell it to refresh
The cause of the bug was due to personListPanel not refreshing. Note that calling
personListView.refresh();
is not sufficient to refresh the entire component. setting items and cell factory does a "refresh".This closes #47 .