Refactor Email to Remark #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathantjendana
force-pushed
the
branch-refactor-remark
branch
from
bd709c7 to
0af5eb7
Compare
src/test/java/seedu/address/storage/JsonSerializableAddressBookTest.java
Show resolved
Hide resolved
src/test/java/seedu/address/storage/JsonSerializableAddressBookTest.java
Outdated
Show resolved
Hide resolved
jonathantjendana
force-pushed
the
branch-refactor-remark
branch
2 times, most recently
from
dafbad8 to
3dd7403
Compare
Nanosync
reviewed
Oct 17, 2019
src/test/java/seedu/address/logic/commands/CommandTestUtil.java
Outdated
Show resolved
Hide resolved
jonathantjendana
force-pushed
the
branch-refactor-remark
branch
from
5159e25 to
fb0428c
Compare
Nanosync
reviewed
Oct 17, 2019
| } | ||
|
|
||
| @Test | ||
| public void parseEmail_invalidValue_throwsParseException() { |
There was a problem hiding this comment.
To fix the coverage bug, try throwing a parse exception when a string of " " only is detected for remark
26 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.