Remove BlockingUtils#asIO & monix-bio optional dependency #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, we've ran into a problem, where some usages of `BlockingUtils` which involved Java code would not respect the optionality of monix-bio on the classpath. Since there's only a single usage for monix-bio in the commons library and the maintenance status of the library is questionable, I'd like to propose removing the optional dependency. Removed method can be easily restored in the projects if at all needed.
sebaciv
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we've ran into a problem, where some usages of
BlockingUtilswhich involved Java code would not respect the optionality of monix-bio on the classpath. Since there's only a single usage for monix-bio in the commons library and the maintenance status of the library is questionable, I'd like to propose removing the optional dependency. Removed method can be easily restored in the projects if at all needed.