Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative image path for downloaded diagrams #16

Closed

Conversation

ssaraswati
Copy link

Remove the / from _save_kroki_image_and_get_url so that generated mkdocs images can be served on non root domains or within Backstages techdocs.

This more closely matches the previous behavior before HttpMethod option #7

@ghost
Copy link

ghost commented Dec 12, 2022

This would break the codebase. The URLs it would provide are only useful for the topmost level of the docs. See my fix in #20 which works for any document.

@ghost ghost mentioned this pull request Jan 4, 2023
@b-bittner
Copy link
Contributor

@ssaraswati ,
would you also agree, that #20 would fix your problem also?

@b-bittner
Copy link
Contributor

fixed with #20

@b-bittner b-bittner closed this Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants