-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for automatic setup of TLS for HTTPS #4417
Conversation
… to remove --listen or not knowing what it is really doing
I rarely ever pull into my local before Auto approves, but this one I need. I've tried to figure out how to add HTTPS on my own and ran into all sort of noob issues that will take me longer to learn. Thanks for this! |
I'd very much prefer if this was an extension. |
Converting to -> extension |
@36DB Could you add my extension implementation for this PR to the extensions index? |
@papuSpartan Sure but I would need the basic template. I have the permissions to add but have little knowledge to write it myself 😅 |
You would need to add that object to the main extensions array. For testing I just put it right at the end after "old localizations". Tested on my machine by loading the modified index in the webui and it seemed to work properly. |
This is the modified version I was able to load in the webui: https://gist.github.com/papuSpartan/c32cb0f3c59ec15a7bbb7de56c056389. Also, It might be helpful to save the extensions index file in a prettified format just so that it is easier to read straight from the wiki without something parsing it. (I used jq for this but any other json prettifier should work) |
@ClashSAN Mind if you add this? I got some RL issues and probably can't add edit the file for few days. |
Looks like someone added it to the list. Thanks |
In #948, users expressed that they wished to be able to use the webui using HTTPS. This PR enables a user to enable TLS, and effectively HTTPS, by adding one command line switch.
If
--self-sign
is passed with no arguments, it will attempt to generate a key/cert pair for the user and will also add the newly generated certificate to the certifi trust store. This means that, in most cases, the user can simply add--self-sign
, and use TLS/HTTPS. Additionally, one can pass in their own key/cert pair using--tls-certfile
and--tls-keyfile
in order to add their own certificate to the certifi trust store without having to manually edit it themselves.