Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort VAE #12297

Merged
merged 1 commit into from
Aug 4, 2023
Merged

sort VAE #12297

merged 1 commit into from
Aug 4, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Aug 4, 2023

Description

alternative to PR #12281
but instead sort VAE dictionary at the source
this way that the it's applied across the UI

remaks
to be honest I think the VAE is left or needs to be revamped
irrc currently one can accidentally use a 1.x VAE on a XL model
unless one is deliberately trying to create a bad image one should never do that

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner August 4, 2023 04:02
@AUTOMATIC1111
Copy link
Owner

dicts are ordered in python
there's no need for OrderedDict
Also there is shared.natural_sort_key

@w-e-w
Copy link
Collaborator Author

w-e-w commented Aug 4, 2023

forgot to mention, I push the change your asked

yeah sometimes I forget that dictionaries already ordered

@AUTOMATIC1111 AUTOMATIC1111 merged commit 0916591 into dev Aug 4, 2023
brkirch pushed a commit to brkirch/stable-diffusion-webui that referenced this pull request Aug 4, 2023
@AUTOMATIC1111 AUTOMATIC1111 deleted the sort-VAE branch August 5, 2023 06:33
@w-e-w w-e-w mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants