🐛 Allow Script to have custom metaclass #11264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the code was checking whether
script_class
is a class by checking whether it hastype
as metaclass, but this implicitly disallowsScript
classes in extensions to have custom metaclass.This PR change the implementation to use
inspect.isclass
to perform the check so thatScript
classes can have custom metaclass.Original PR that adds the code:
b523019#diff-e4bc1c55946593391fac69500badc7f35ca9efb23ced1064856ce79fd53f29ceR204
Screenshots/videos:
Checklist: