Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jobs Submit form -> reactive form #78

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nick97eagles
Copy link
Contributor

Changes

The submit form for jobs was a regular form with no validation. I'm currently working on updating it to be a reactive angular form with validation

@nick97eagles
Copy link
Contributor Author

This is related to issue #69

@ermsdev
Copy link
Member

ermsdev commented May 13, 2020

make sure you fix the conflict in:

{
<<<<<<< HEAD
"extends": "../tslint.json",
"rules": {
"directive-selector": [
true,
"attribute",
"app",
"camelCase"
],
"component-selector": [
true,
"element",
"app",
"kebab-case"
]
}
=======
"extends": "../tslint.json",
"rules": {
"directive-selector": [
true,
"attribute",
"app",
"camelCase"
],
"component-selector": [
true,
"element",
"app",
"kebab-case"
]
}
>>>>>>> elections/master
}

@ermsdev
Copy link
Member

ermsdev commented May 20, 2020

Current Status:

This PR is on hold until the Pages site is merged into the frontend repository. It's looking like there will be some significant changes to how the form is stored or managed in the submit typescript file before reactive forms can be implemented.

@ermsdev ermsdev added the on hold Progress on this ticket is paused. label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Progress on this ticket is paused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants