Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct scan parameters types #15515

Merged
merged 2 commits into from
Jun 8, 2024
Merged

Correct scan parameters types #15515

merged 2 commits into from
Jun 8, 2024

Conversation

matkammusic
Copy link
Contributor

Summary of changes

This PR fixes the scan parameters definition, especially the scan_interval & and the scan_window definition.

Impact of changes

Migration actions required

Documentation

None.


Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@matkammusic matkammusic marked this pull request as draft May 16, 2024 10:51
@matkammusic matkammusic marked this pull request as ready for review May 16, 2024 10:53
0xc0170
0xc0170 previously approved these changes May 21, 2024
@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels May 21, 2024
@mergify mergify bot dismissed 0xc0170’s stale review May 22, 2024 06:53

Pull request has been modified.

@matkammusic
Copy link
Contributor Author

I have noticed the error was also in the ScanParameters getters, I've also changed it there

@mbed-ci
Copy link

mbed-ci commented May 27, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test

@mergify mergify bot added needs: work and removed needs: CI labels May 27, 2024
@0xc0170 0xc0170 merged commit 5249bb9 into ARMmbed:master Jun 8, 2024
19 of 21 checks passed
@mergify mergify bot removed the ready for merge label Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants