Handle negative values passed to close() #15431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling close() with negative numbers causes out-of-bounds indexing of the filehandles array. For example, this can happen if open() returns an error and the value is later passed to close().
0xc0170
previously requested changes
Jun 15, 2023
platform/source/mbed_retarget.cpp
Outdated
| @@ -656,6 +656,11 @@ extern "C" int PREFIX(_close)(FILEHANDLE fh) | |||
| #if !MBED_CONF_PLATFORM_STDIO_MINIMAL_CONSOLE_ONLY | |||
| extern "C" int close(int fildes) | |||
| { | |||
| if (fildes < 0) | |||
| { | |||
There was a problem hiding this comment.
this should be aligned to if statement (line 659 please)
0xc0170
added
needs: work
release-type: patch
Moved a { to the same line as if
0xc0170
approved these changes
Jun 26, 2023
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
0xc0170
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Calling close() with negative numbers causes out-of-bounds indexing of the filehandles array. For example, this can happen if open() returns an error and the value is later passed to close(). The fix simply returns the correct error code for an invalid file descriptor.
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers