Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed-os-5.15: Add initialization check to RADIUS ipv6 address #13774

Merged
merged 1 commit into from
Oct 30, 2020
Merged

mbed-os-5.15: Add initialization check to RADIUS ipv6 address #13774

merged 1 commit into from
Oct 30, 2020

Conversation

mikaleppanen
Copy link

Summary of changes

Added initialization check to RADIUS ipv6 address that prevents the border router from printing unnecessary error trace
when RADIUS is not enabled.

This is Mbed OS 5.15 version of:

#13588

Impact of changes

None

Migration actions required

None

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @artokin

Added initialization check to RADIUS ipv6 address
f5cad83 
Added initialization check to RADIUS ipv6 address that prevents the border router from printing unnecessary error trace
when RADIUS is not enabled.
@ciarmcom ciarmcom requested review from artokin, mikter and a team October 16, 2020 12:00
@ciarmcom
Copy link
Member

@mikaleppanen, thank you for your changes.
@mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Oct 16, 2020
@0xc0170 0xc0170 changed the title [mbed-os-5.15] Added initialization check to RADIUS ipv6 address mbed-os-5.15: Add initialization check to RADIUS ipv6 address Oct 21, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 requested a review from andypowers October 22, 2020 15:05
andypowers
andypowers approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit 30076a4 into ARMmbed:mbed-os-5.15 Oct 30, 2020
@mergify mergify bot removed the ready for merge label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@artokin artokin artokin approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@mikter mikter Awaiting requested review from mikter

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikaleppanen @ciarmcom @0xc0170 @mbed-ci @artokin @andypowers