-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mbed-os-5.15: Nuvoton: Fix NuMaker I2C timeout #13709
mbed-os-5.15: Nuvoton: Fix NuMaker I2C timeout #13709
Conversation
some H/W timer count is 24 bits only, hardcode 0xffffffff causing wrong judgement of timeout as while H/W timer counting overflow.
@cyliangtw, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
CI started |
CI restarted |
@cyliangtw Can you review line endings for files in this PR:
Please fix |
@0xc0170 , Hi |
If I follow the steps here on Github, I am on 5.15 branch:
git status
git diff:
There are line endings errors. |
Would |
If executing above command, it should be simple to just amend the previous comments to fix it. I would like to start CI asap to get this in for the next release (early next week). |
Pull request has been modified.
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
Summary of changes
This PR is to fix I2C timeout measurement for NuMaker platforms instead of hardcode max timer count on OS-5.15 branch.
The same commit got approval in PR #13679 on OS-6.x master branch.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers
@0xc0170
@andypowers