Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mbed-os-5.15] Add WiSun network size configs in JSON #13495

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[mbed-os-5.15] Add WiSun network size configs in JSON #13495

merged 1 commit into from
Sep 30, 2020

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Aug 26, 2020

Summary of changes

Add json config items for WiSun network size.
So user could easily config the default WiSun network size via Json file.

This PR is upstreaming changes from #13134

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom requested a review from a team August 26, 2020 08:00
@ciarmcom
Copy link
Member

@artokin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2020

I restarted travis, 5.15 branch should contain the updated gcc arm version. It should pass this time.

@0xc0170 0xc0170 requested a review from andypowers August 31, 2020 17:22
@mergify mergify bot added needs: CI and removed needs: review labels Aug 31, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 3, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@artokin artokin closed this Sep 7, 2020
@artokin artokin deleted the upstream_mesh_network_size_api_to_5_15 branch September 7, 2020 10:07
@artokin artokin restored the upstream_mesh_network_size_api_to_5_15 branch September 7, 2020 10:07
@artokin artokin reopened this Sep 7, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2020

@artokin All fine and ready ? I've just found this one it was restored

@artokin
Copy link
Contributor Author

artokin commented Sep 8, 2020

@0xc0170 , everything is ok. I just accidentally deleted the branch and therefore this extra hassle.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

All fine, I restart testing and we shall integrate this soon.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

andypowers
andypowers approved these changes Sep 30, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 merged commit b67e542 into ARMmbed:mbed-os-5.15 Sep 30, 2020
@mergify mergify bot removed the ready for merge label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypowers andypowers andypowers approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@mikter mikter mikter approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@fredlee12001 fredlee12001 Awaiting requested review from fredlee12001

@JarkkoPaso JarkkoPaso Awaiting requested review from JarkkoPaso

@juhhei01 juhhei01 Awaiting requested review from juhhei01

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@artokin @ciarmcom @0xc0170 @mbed-ci @mikter @mikaleppanen @andypowers @fredlee12001