This repository has been archived by the owner on Aug 19, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a C++ style function API that allows the event class to be easily passed as an argument to existing callback based APIs:
The previous discussion on this subject can be found here: #15
In reviewing the pr, don't think there are problems with introducing the callable interface. This design is compatible with passing function objects by both reference and by value, and adds convenient integration with existing C and C++ callback APIs without creating a special case for mbed OS.
There is a concern that this interface would encourage users to use the unclear
event()
syntax. But this can be discouraged through documentation.cc @pan-