Skip to content

Add requirements #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2019
Merged

Add requirements #884

merged 2 commits into from
Apr 11, 2019

Conversation

bridadan
Copy link
Contributor

Fixes #880.

Both pyserial and mbed-ls (now using the mbed-os-tools package) are called directly by Mbed CLI, so let's add them as Python requirements.

Because mbed-os-tools is now a direct requirement, we can remove the try/except block to catch the import error.

@bridadan bridadan requested a review from theotherjimmy April 11, 2019 15:25
@bridadan bridadan merged commit ff6b14a into ARMmbed:master Apr 11, 2019
@mark-edgeworth mark-edgeworth mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@theotherjimmy theotherjimmy theotherjimmy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bridadan @theotherjimmy