Improvements and stuff #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the two functions cortex_int_get_and_disable and cortex_int_restore. This allows interrupts to be disabled globally.
Remove ENABLE_USB_IRQ and DISABLE_USB_IRQ from flash_hal_svc.c and instead disable interrupts globally. Also remove the macros to disable the USB interrupt from IO_Config.h since this macro is no longer used.
Add the macros ROUND_UP and ROUND_DOWN to make rounding easier.
Update yaml files for progen by explicitly adding include directories along with removing an empty uvision specific yaml file.
If any endpoint is set to 0 and has a size greater than zero then it will override the stack size of endpoint 0. This patch prevents that from occurring by giving an error if that happens.
|
test this please |
|
+1 for updating yaml files, working now with v0.8 ? |
|
for the yaml updates - include was derived from - source. Are we depreciating that feature or is this for clearness? |
|
Looks good. Next thing we need to do is align on coding style. I'll suggest we stick to https://developer.mbed.org/teams/SDK-Development/wiki/mbed-sdk-coding-style |
BlackstoneEngineering
pushed a commit
to BlackstoneEngineering/DAPLink
that referenced
this pull request
Dec 13, 2016
Correct form field validation
wjzhang
pushed a commit
to wjzhang/DAPLink
that referenced
this pull request
Mar 11, 2019
Add back fixing for no nReset connected problem.
gerargz
added a commit
to microbit-foundation/DAPLink
that referenced
this pull request
Jan 6, 2021
mbrossard
pushed a commit
to mbrossard/DAPLink
that referenced
this pull request
Aug 5, 2021
c1728p9
pushed a commit
to c1728p9/DAPLink
that referenced
this pull request
Aug 14, 2021
mathias-arm
pushed a commit
to mathias-arm/DAPLink
that referenced
this pull request
Aug 20, 2021
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
gaborcsapo
pushed a commit
to gaborcsapo/DAPLink
that referenced
this pull request
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add additional checking on USB configuration
-Add utility functions to round and disable interrupts
-Update yaml files in preperation for pgen
-Disable all interrupts when flashing rather than just usb interrupts