Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS test_c021.c only check HAFDBS[3:0] = 0b0010 #488

Closed
hensonwang opened this issue Oct 10, 2024 · 0 comments
Closed

ACS test_c021.c only check HAFDBS[3:0] = 0b0010 #488

hensonwang opened this issue Oct 10, 2024 · 0 comments

Comments

@hensonwang
Copy link

Hi,

I saw ACS test_c021.c only checked ID_AA64MMFR1_EL1.HAFDBS[3:0] = 0b0010 as below:
/* Read ID_AA64MMFR1_EL1.HAFDBS[3:0] = 0b0010 For Hardware update supported */
data = VAL_EXTRACT_BITS(val_pe_reg_read(ID_AA64MMFR1_EL1), 0, 3);
if (data != 2)
val_set_status(index, RESULT_FAIL(TEST_NUM, 01));
else
val_set_status(index, RESULT_PASS(TEST_NUM, 01));
}

Do you plan to add ID_AA64MMFR1_EL1.HAFDBS[3:0] = 0b0011 to check if PE support dirty bit update + HAFT Table AF update which added in ARM V9.4?

Thanks!

rajatgoyal47 added a commit to rajatgoyal47/arm-sbsa-acs that referenced this issue Oct 14, 2024
 - Test checks for all values >= 0b0010

Signed-off-by: Rajat Goyal <Rajat.Goyal@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant