-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup for P2P tests 817 and 819 #352
Comments
Sujana-M
added a commit
to Sujana-M/sbsa-acs
that referenced
this issue
Oct 24, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com> Change-Id: Ic86d64a6b2be2c6c3c1bcd6fd72e3adb2e1428d4
Sujana-M
added a commit
to Sujana-M/bsa-acs
that referenced
this issue
Oct 24, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com>
Sujana-M
added a commit
to Sujana-M/sbsa-acs
that referenced
this issue
Oct 24, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com>
Sujana-M
added a commit
to Sujana-M/bsa-acs
that referenced
this issue
Oct 25, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com>
Merged
chetan-rathore
pushed a commit
that referenced
this issue
Oct 25, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com>
chetan-rathore
pushed a commit
to ARM-software/sbsa-acs
that referenced
this issue
Oct 25, 2024
- val_pcie_p2p_support API either return non_implemented or 0. having it twice is redundant, hence removed it in tests - In addition to the devices, the PCIe hierarchy also need to support P2P. hence added P2P check for PCIe hierarchy as well Signed-off-by: Sujana M <sujana.murali@arm.com>
Thanks for making the changes for the cleanup, @chetan-rathore and @Sujana-M. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
P2P (Peer-to-Peer) rules in BSA spec are conditional requirements and only applicable when the system supports P2P. Since there is no way for test suite to know if system supports P2P, using -p2p option with bsa-acs is required for users to run the P2P tests.
For tests 817 and 819, there is no message about using -p2p option. Also, test 817 is always executed regardless of P2P support. Therefore, I think we need to add the code block below to both tests.
Also, it looks like the second val_pcie_p2p_support() code block in tests 901, 902, 818, 819 is redundant. Please check and remove them.
The text was updated successfully, but these errors were encountered: